On Thu, Jul 6, 2017 at 2:03 PM, Luigi Toscano <luigi.tosc...@tiscali.it> wrote:
> Lays Rodrigues ha scritto: > > Hi guys of kde-core. > > > > Any new review of AtCore? =D > > I think that there were questions open on your side. Did you address the > two > issues, namely: > > > On Fri, Jun 23, 2017 at 11:19 PM, Lays Rodrigues wrote: > > > -> aacid > > > > "Partially, i personally still think it'd be better if you move the > > PrinterState AXIS and MeasuramentUnits enums inside AtCore (or make > them C++11 > > "enum class"). > > > > Also note how PrinterState AXIS MeasuramentUnits is not consistent > naming > > " > > > > For that, I think this is the diff: https://phabricator.kde.org/ > D6363 > > <https://phabricator.kde.org/D6363> > > This seems to be merged; Albert, does it address your concern? > > > > > > -> Luigui > > "In addition to Albert's comment, I noticed now (still going through > the > > backlog after vacation) that atcore use tr() for messages, but there > is no > > Messages.sh file to extract the strings (which should be called > atcore_qt, > > check the similar files in step or marble or in tier1 frameworks)." > > I don't think that this has been addressed > It was not, and it's my fault. I was looking on marble sources but I didn't understood how the Messages.sh works, I'm reading and will update that as soon as I can. > > -- > Luigi >
