On Friday, 6 October 2017 09:47:26 CEST Jonathan Riddell wrote: > Looks good from a brief look around I did from a packagers point of > view (so not looking at the code).
The licensing is a funky (not bad, just .. unusual) mix of LGPL v2+ and GPL v2+; for instance app/ contains 7 files licensed LGPL v2+, the rest looks like GPL v2+. The code doesn't compile with clang. extras.h contains a definition of make_unique() for old GLIBCXX. That doesn't seem consistent with the required C++ version, C++14. The check is also wrong for clang / libstc++ , since it probably doesn't define __GLIBCXX__ at all. That definition should probably just be removed. visibilitymanager_p.h is missing <array> as an include -- probably g++ #includes it via some round-about path, but clang / libstdc++ doesn't. [ade]
signature.asc
Description: This is a digitally signed message part.