> On June 4, 2014, 2:55 p.m., Vishesh Handa wrote: > > I'm not too sure about this. I was planning on moving the runners, kcm and > > kioslaves out of the baloo repository and into plasma-desktop and > > plasma-workspace. This just leaves the executables, which IMO should > > overwrite the old ones, but that would be a problem, right? > > Heiko Becker wrote: > Well, splitting it out would work for us, too. So that leaves the > binaries. If they shouldn't be renamed it would to nice to have a cmake > option in order to decide if they should be build. That way we could provide > packages with an option allowing the user to build and install the binaries > for the version he wants (probably matching his version of Plasma workspaces). > > I'd be willing to adjust this patch to only make the building of binaries > depending on a cmake option, if it's alright with you. >
Just to confirm, this patch would also need to go in the KDE4 version as well, right? - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118438/#review59206 ----------------------------------------------------------- On May 31, 2014, 11:54 a.m., Heiko Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118438/ > ----------------------------------------------------------- > > (Updated May 31, 2014, 11:54 a.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > The intention behind this review request is to make it easier to turn baloo > into a framework and make it coinstallable with its KDE4 counterpart in a > second review request. > > That being said I'm not exactly sure this is the way you guys want to go, but > I'd be willing to update my review request accordingly if you have other > plans to make it coinstallable. > > > Diffs > ----- > > src/CMakeLists.txt de044025012ebcccb8a9c7293edfe045cc9b7856 > src/file/CMakeLists.txt 4f9fb9dd6b0e680a5f70cfaeb3986000cb192acd > > Diff: https://git.reviewboard.kde.org/r/118438/diff/ > > > Testing > ------- > > cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE .. > make > make install > > I've also built the frameworks branch of milou against it (needed a few > modifications). > > > Thanks, > > Heiko Becker > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
