----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118438/#review62131 -----------------------------------------------------------
src/CMakeLists.txt <https://git.reviewboard.kde.org/r/118438/#comment43198> Shouldn't this be in the main CMakeLists.txt? src/CMakeLists.txt <https://git.reviewboard.kde.org/r/118438/#comment43199> This isn't entirely correct, since you still want to install the pim search plugin. Don't you? src/file/CMakeLists.txt <https://git.reviewboard.kde.org/r/118438/#comment43200> Ditto. Do you still want the search plugin? Without it the core library is useless. - Vishesh Handa On July 11, 2014, 8:16 a.m., Heiko Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118438/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 8:16 a.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > The intention behind this review request is to make it easier to turn baloo > into a framework and make it coinstallable with its KDE4 counterpart in a > second review request. > > That being said I'm not exactly sure this is the way you guys want to go, but > I'd be willing to update my review request accordingly if you have other > plans to make it coinstallable. > > > Diffs > ----- > > src/CMakeLists.txt 810f6dcd97b5f3ff64962709efbfffec7fa9a257 > src/file/CMakeLists.txt 72b56ea5fb63c1bece1b4959ea5bf7ee3af994b0 > > Diff: https://git.reviewboard.kde.org/r/118438/diff/ > > > Testing > ------- > > cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE .. > make > make install > > I've also built the frameworks branch of milou against it (needed a few > modifications). > > > Thanks, > > Heiko Becker > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
