> On août 5, 2014, 8:20 matin, David Faure wrote: > > Looks good to me. I hope the commit log isn't the same as the reviewboard > > description though - it should be about what the patch does, instead.
The commit log is : ------------------- examples/kdeui/kmessagewidgetdemo : Port to KF5 Change Build system to be KF5 compatible Remove deprecated KAboutData, KCmdLineArgs Replace KApplication with QApplication Repalce KMainWindow with QMainWindow Replace KAction with QAction Replace KIcon with QIcon Replace KLocale with KLocalizedString Replace KTextEdit with QTextEdit - Laurent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review63828 ----------------------------------------------------------- On août 4, 2014, 10:51 après-midi, Laurent Navet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114933/ > ----------------------------------------------------------- > > (Updated août 4, 2014, 10:51 après-midi) > > > Review request for KDE Examples and Sune Vuorela. > > > Repository: kdeexamples > > > Description > ------- > > This is part of Google Code-IN Contest. > As I'm no more student, I've waited for the end of the contest to work on it. > > Comments appreciated, > > > Diffs > ----- > > kdeui/kmessagewidgetdemo/CMakeLists.txt 12ef4ac > kdeui/kmessagewidgetdemo/main.cpp d3a5bf0 > kdeui/kmessagewidgetdemo/window.h d3a67c8 > kdeui/kmessagewidgetdemo/window.cpp 9786da6 > > Diff: https://git.reviewboard.kde.org/r/114933/diff/ > > > Testing > ------- > > Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit > I've commented the line. > > > Thanks, > > Laurent Navet > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
