> On Aug. 5, 2014, 6:20 a.m., David Faure wrote: > > Looks good to me. I hope the commit log isn't the same as the reviewboard > > description though - it should be about what the patch does, instead. > > Laurent Navet wrote: > The commit log is : > ------------------- > examples/kdeui/kmessagewidgetdemo : Port to KF5 > > Change Build system to be KF5 compatible > > Remove deprecated KAboutData, KCmdLineArgs > Replace KApplication with QApplication > Repalce KMainWindow with QMainWindow > Replace KAction with QAction > Replace KIcon with QIcon > Replace KLocale with KLocalizedString > Replace KTextEdit with QTextEdit
Looks good. Tip for next time: when using tools such as post-review, the commit log ends up directly in reviewboard ;) You don't see to have a git account; Sune pushes your commits? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review63828 ----------------------------------------------------------- On Aug. 4, 2014, 8:51 p.m., Laurent Navet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114933/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2014, 8:51 p.m.) > > > Review request for KDE Examples and Sune Vuorela. > > > Repository: kdeexamples > > > Description > ------- > > This is part of Google Code-IN Contest. > As I'm no more student, I've waited for the end of the contest to work on it. > > Comments appreciated, > > > Diffs > ----- > > kdeui/kmessagewidgetdemo/CMakeLists.txt 12ef4ac > kdeui/kmessagewidgetdemo/main.cpp d3a5bf0 > kdeui/kmessagewidgetdemo/window.h d3a67c8 > kdeui/kmessagewidgetdemo/window.cpp 9786da6 > > Diff: https://git.reviewboard.kde.org/r/114933/diff/ > > > Testing > ------- > > Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit > I've commented the line. > > > Thanks, > > Laurent Navet > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
