----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120780/#review69108 -----------------------------------------------------------
src/qml/balooquerymodel.h <https://git.reviewboard.kde.org/r/120780/#comment48313> Could you please loose the "Baloo" in BalooQueryModel. You can put it in the Baloo namespace. Also, I'm still not entirely sure of the name. How about QueryResultsModel? Just QueryModel seems to indiciate it's holding queries. Maybe someone else can chime in? - Vishesh Handa On Oct. 24, 2014, 2:30 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120780/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 2:30 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > So the BalooDataModel gets renamed to BalooQueryModel. > Also we are replacing the Query::setTypes, Query::type with the > Query::setSearchString, Query::searchString in order to make > our model more flexible > > > Diffs > ----- > > src/qml/balooquerymodel.h PRE-CREATION > src/qml/balooquerymodel.cpp PRE-CREATION > src/qml/CMakeLists.txt bfcb774 > src/qml/baloodatamodel.h 0560d9c > src/qml/baloodatamodel.cpp 281d721 > src/qml/balooplugin.cpp fda7bdd > > Diff: https://git.reviewboard.kde.org/r/120780/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
