> On Oct. 24, 2014, 3:39 p.m., Vishesh Handa wrote: > > src/qml/balooquerymodel.h, line 55 > > <https://git.reviewboard.kde.org/r/120780/diff/1/?file=321965#file321965line55> > > > > Could you please loose the "Baloo" in BalooQueryModel. You can put it > > in the Baloo namespace. > > > > Also, I'm still not entirely sure of the name. How about > > QueryResultsModel? Just QueryModel seems to indiciate it's holding queries. > > Maybe someone else can chime in? > > Antonis Tsiapaliokas wrote: > If we put the QueryResultsModel into a namespace, then we must rename our > "Query" class into something else or using it as "::Query", > otherwise the compiler will complain, because "Baloo::Query" already > exists and it is inside our core library. > > Antonis Tsiapaliokas wrote: > Any suggestions about this one? > > Vishesh Handa wrote: > Oh. I didn't see. > > Well, avoid putting it under the Jungle namespace or rename it to > something.
I have update my patch and i have follow your idea. (BalooQueryModel gets renamed to QueryResultsModel). - Antonis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120780/#review69108 ----------------------------------------------------------- On Nov. 5, 2014, 12:46 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120780/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 12:46 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > So the BalooDataModel gets renamed to BalooQueryModel. > Also we are replacing the Query::setTypes, Query::type with the > Query::setSearchString, Query::searchString in order to make > our model more flexible > > > Diffs > ----- > > src/qml/queryresultsmodel.cpp PRE-CREATION > src/qml/baloodatamodel.h 0560d9c > src/qml/baloodatamodel.cpp df1569a > src/qml/balooplugin.cpp fda7bdd > src/qml/queryresultsmodel.h PRE-CREATION > src/qml/CMakeLists.txt bfcb774 > > Diff: https://git.reviewboard.kde.org/r/120780/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
