----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123863/#review80691 -----------------------------------------------------------
This is a good start. Also, why don't you request a developer account. That way you cannot commit this on your own. src/file/extractor/result.cpp (line 109) <https://git.reviewboard.kde.org/r/123863/#comment55319> This approach would break if/when the value of 'LastProperty' changed. Also, we're wasting a lot of space by mapping <integer, bool>. Perhaps there is a better way? src/file/extractor/result.cpp (line 111) <https://git.reviewboard.kde.org/r/123863/#comment55317> Please correct the coding style. A space after the if. src/lib/file.h (line 70) <https://git.reviewboard.kde.org/r/123863/#comment55318> Please make this const. src/lib/file.cpp (line 116) <https://git.reviewboard.kde.org/r/123863/#comment55320> Maybe we should move all of this to a special decoder class? It could take the QByteArray as input and then give us the properties and types. We do the same decoding in src/tools/balooshow/main.cpp. This way we can avoid duplicating the code. src/lib/file.cpp (line 142) <https://git.reviewboard.kde.org/r/123863/#comment55321> Coding style :) - Vishesh Handa On May 20, 2015, 2:47 p.m., John Freeman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123863/ > ----------------------------------------------------------- > > (Updated May 20, 2015, 2:47 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > Result encodes the QVector<KFileMetaData::Type::Type> into Document::m_data, > and File::load() retrieves the Type::Type encoded into the data and assigns > it to the private info, added types() function to File to retrieve > QVector<KFileMetaData::Type::Type> from the private info. > > > Diffs > ----- > > src/file/basicindexingjob.h f5e64c8 > src/file/extractor/result.cpp 072aebc > src/lib/file.h b92504b > src/lib/file.cpp 13dff88 > > Diff: https://git.reviewboard.kde.org/r/123863/diff/ > > > Testing > ------- > > All passed except #30 > > > Thanks, > > John Freeman > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
