----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123863/#review80728 -----------------------------------------------------------
Could you please also update balooshow/main.cpp to use this codec? autotests/unit/lib/CMakeLists.txt (line 27) <https://git.reviewboard.kde.org/r/123863/#comment55343> If you want you can just make KF5::BalooCodecs PUBLIC in src/engine/CMakeLists.txt. Then you won't have to link it everywhere. src/codecs/typescodec.h (line 10) <https://git.reviewboard.kde.org/r/123863/#comment55349> Could you please change this class to DocumentDataCodec, and encode both the properties and the types in one function? All of the json releated code would also go in here. src/codecs/typescodec.cpp (line 12) <https://git.reviewboard.kde.org/r/123863/#comment55346> Please reserve the size of the QByteArray before appending. src/codecs/typescodec.cpp (line 21) <https://git.reviewboard.kde.org/r/123863/#comment55347> Again, please reserve the size if possible. src/codecs/typescodec.cpp (line 22) <https://git.reviewboard.kde.org/r/123863/#comment55348> Coding style src/file/extractor/result.cpp (line 134) <https://git.reviewboard.kde.org/r/123863/#comment55344> You only seem to be encoding the types from the BasicIndexingJob, not the ones from the extractor. Unless I'm missing something. src/lib/file.cpp (line 121) <https://git.reviewboard.kde.org/r/123863/#comment55345> Coding Style. - Vishesh Handa On May 22, 2015, 1:08 a.m., John Freeman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123863/ > ----------------------------------------------------------- > > (Updated May 22, 2015, 1:08 a.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > Result encodes the QVector<KFileMetaData::Type::Type> into Document::m_data, > and File::load() retrieves the Type::Type encoded into the data and assigns > it to the private info, added types() function to File to retrieve > QVector<KFileMetaData::Type::Type> from the private info. > > > Diffs > ----- > > autotests/unit/lib/CMakeLists.txt 871bf8d > src/codecs/CMakeLists.txt 9df7796 > src/codecs/typescodec.h PRE-CREATION > src/codecs/typescodec.cpp PRE-CREATION > src/file/CMakeLists.txt 8158b7f > src/file/basicindexingjob.h f5e64c8 > src/file/extractor/CMakeLists.txt 529374a > src/file/extractor/result.cpp 072aebc > src/lib/CMakeLists.txt e0aad3f > src/lib/file.h b92504b > src/lib/file.cpp 13dff88 > > Diff: https://git.reviewboard.kde.org/r/123863/diff/ > > > Testing > ------- > > All passed except #30 > > > Thanks, > > John Freeman > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
