-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123964/
-----------------------------------------------------------

Review request for Baloo and Vishesh Handa.


Repository: baloo


Description
-------

This patch adds: 
* batch committing to the new extractor. 
* Also drop QTextStreams
* use simple read/write. We now have a class IOHandler which, takes care of 
reading/writting for the extractor. This makes testing easier (test for class 
is included in this patch). 

notes: This patch doesn't take care of extractor getting stuck (will be added 
in a later patch). baloo_file_extractor is using a lot of memory, which needs 
to be debugged.


Diffs
-----

  src/file/extractor/CMakeLists.txt 529374a 
  src/file/extractor/app.h 856995a 
  src/file/extractor/app.cpp eda4ee0 
  src/file/extractor/autotests/CMakeLists.txt 166d36b 
  src/file/extractor/autotests/iohandlertest.cpp PRE-CREATION 
  src/file/extractor/iohandler.h PRE-CREATION 
  src/file/extractor/iohandler.cpp PRE-CREATION 
  src/file/fileindexingqueue.h 9b3cc18 
  src/file/fileindexingqueue.cpp 818f577 
  src/file/indexingqueue.h 4bea209 

Diff: https://git.reviewboard.kde.org/r/123964/diff/


Testing
-------

IOhandler class is tested with the included test, baloo_file seems to be 
working normally.


Thanks,

Pinak Ahuja

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Reply via email to