----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123964/#review81072 -----------------------------------------------------------
Ship it! Good work. Next time. This should be 3 different patches - * One for moving away from QTextStream * One for the IO handler * One for doing batch commiting Commit it! src/file/extractor/iohandler.h (line 31) <https://git.reviewboard.kde.org/r/123964/#comment55502> I'm not too fond of the requirement to remember to cal 'batchIndexed' and 'newBatch'. We could just return a QVector<quint64> instead of returning them one at a time via 'nextId'. But we can fix that later. src/file/extractor/iohandler.h (line 49) <https://git.reviewboard.kde.org/r/123964/#comment55503> You do not really need this variable. You could just decrease the `m_batchSize` each time. - Vishesh Handa On June 1, 2015, 4:33 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123964/ > ----------------------------------------------------------- > > (Updated June 1, 2015, 4:33 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > This patch adds: > * batch committing to the extractor over stdin. > * drop QTextStreams. > * We now have a class IOHandler which, takes care of reading/writting for the > extractor. This makes testing easier (test for class is included in this > patch). > * Fixes baloo_file_extractor taking loads of memory. We reopen database for > every transaction (for now). > > notes: This patch doesn't take care of extractor getting stuck (will be added > in a later patch) > > > Diffs > ----- > > src/file/extractor/CMakeLists.txt 529374a > src/file/extractor/app.h 856995a > src/file/extractor/app.cpp eda4ee0 > src/file/extractor/autotests/CMakeLists.txt 166d36b > src/file/extractor/autotests/iohandlertest.cpp PRE-CREATION > src/file/extractor/iohandler.h PRE-CREATION > src/file/extractor/iohandler.cpp PRE-CREATION > src/file/fileindexingqueue.h 9b3cc18 > src/file/fileindexingqueue.cpp 818f577 > src/file/indexingqueue.h 4bea209 > > Diff: https://git.reviewboard.kde.org/r/123964/diff/ > > > Testing > ------- > > IOhandler class is tested with the included test, baloo_file seems to be > working normally. > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
