----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124019/#review81239 -----------------------------------------------------------
src/engine/transaction.h (line 55) <https://git.reviewboard.kde.org/r/124019/#comment55643> My naming over here is really stupid. I'm using 'phaseOne' in half the places, and 'contentIndexing' is other places. Could you please use 'inPhaseOne' or something similar? Or maybe we should rename all the phaseOne apis. I'm conflicted. Do you want to take a call? src/tools/balooctl/main.cpp (line 161) <https://git.reviewboard.kde.org/r/124019/#comment55646> Maybe 'File: '. src/tools/balooctl/main.cpp (line 168) <https://git.reviewboard.kde.org/r/124019/#comment55647> \n after? src/tools/balooctl/main.cpp (line 172) <https://git.reviewboard.kde.org/r/124019/#comment55644> Maybe we want this to look like - 'Basic Indexing: status' 'Content Indexing: status' Also, I'm not sure what 'BasicIndexing' would mean to a user. Coming up with names is hard :/ - Vishesh Handa On June 5, 2015, 4:52 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124019/ > ----------------------------------------------------------- > > (Updated June 5, 2015, 4:52 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > balooctl status [file..] now tells us if basic indexing of a file is done, > and content indexing of a file is done, scheduled, disabled. > > > Diffs > ----- > > src/engine/transaction.h 870df5a > src/engine/transaction.cpp 4df4f4c > src/tools/balooctl/main.cpp bb35e5b > > Diff: https://git.reviewboard.kde.org/r/124019/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
