> On June 5, 2015, 5:24 p.m., Vishesh Handa wrote: > > src/engine/transaction.h, line 55 > > <https://git.reviewboard.kde.org/r/124019/diff/1/?file=378894#file378894line55> > > > > My naming over here is really stupid. > > > > I'm using 'phaseOne' in half the places, and 'contentIndexing' is other > > places. Could you please use 'inPhaseOne' or something similar? > > > > Or maybe we should rename all the phaseOne apis. I'm conflicted. Do you > > want to take a call?
This is mainly because we use the same thing, in two different contexts, first to mark that phase one index is done on that doc, and second to mark if content indexing needs to be done. I'll just change it to inPhaseOne. > On June 5, 2015, 5:24 p.m., Vishesh Handa wrote: > > src/tools/balooctl/main.cpp, line 182 > > <https://git.reviewboard.kde.org/r/124019/diff/1/?file=378896#file378896line182> > > > > Maybe we want this to look like - > > > > 'Basic Indexing: status' > > 'Content Indexing: status' > > > > Also, I'm not sure what 'BasicIndexing' would mean to a user. Coming up > > with names is hard :/ I couldn't come up with anything other than basic indexing, hence used it. - Pinak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124019/#review81239 ----------------------------------------------------------- On June 5, 2015, 4:52 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124019/ > ----------------------------------------------------------- > > (Updated June 5, 2015, 4:52 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > balooctl status [file..] now tells us if basic indexing of a file is done, > and content indexing of a file is done, scheduled, disabled. > > > Diffs > ----- > > src/engine/transaction.h 870df5a > src/engine/transaction.cpp 4df4f4c > src/tools/balooctl/main.cpp bb35e5b > > Diff: https://git.reviewboard.kde.org/r/124019/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
