----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124024/#review81268 -----------------------------------------------------------
src/engine/database.cpp (line 103) <https://git.reviewboard.kde.org/r/124024/#comment55697> This won't work. DocumentIDDB opens a db with the namem "indexingleveldb". You'll need to give it a unique name. Have a look at how the DocumentDB does it. src/engine/database.cpp (line 130) <https://git.reviewboard.kde.org/r/124024/#comment55698> ditto src/engine/transaction.h (line 56) <https://git.reviewboard.kde.org/r/124024/#comment55696> isFailed vs hasFailed? You choose. - Vishesh Handa On June 6, 2015, 8:44 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124024/ > ----------------------------------------------------------- > > (Updated June 6, 2015, 8:44 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > We will use this database to store file ID's which make baloo_file_extractor > crash or take longer time than the limit. > > > Diffs > ----- > > src/engine/database.cpp 10ac71c > src/engine/databasedbis.h 5082fd7 > src/engine/transaction.h 42ee793 > src/engine/transaction.cpp 91b2b1f > > Diff: https://git.reviewboard.kde.org/r/124024/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
