----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124024/#review81274 -----------------------------------------------------------
Ship it! Good work. Could you also please update the dbState.h file used in integration tests? src/engine/database.cpp (line 100) <https://git.reviewboard.kde.org/r/124024/#comment55709> Minor nitpick. Could you please rearrange the code so that both of these come one line after another m_dbis.contentIndexingDbi = ... m_dbis.failedIdDbi = ... It just looks nicer. src/engine/database.cpp (line 127) <https://git.reviewboard.kde.org/r/124024/#comment55710> ditto - Vishesh Handa On June 6, 2015, 5:31 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124024/ > ----------------------------------------------------------- > > (Updated June 6, 2015, 5:31 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > We will use this database to store file ID's which make baloo_file_extractor > crash or take longer time than the limit. > > > Diffs > ----- > > autotests/unit/engine/documentiddbtest.cpp 3312330 > src/engine/database.cpp 10ac71c > src/engine/databasedbis.h 5082fd7 > src/engine/documentiddb.h d8a0c23 > src/engine/documentiddb.cpp 34bf17c > src/engine/transaction.h 42ee793 > src/engine/transaction.cpp 91b2b1f > > Diff: https://git.reviewboard.kde.org/r/124024/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
