----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124162/#review81840 -----------------------------------------------------------
src/file/extractor/app.h (line 48) <https://git.reviewboard.kde.org/r/124162/#comment56176> Are you sure this works? The syntax seems a bit strange. I thought it should be "... READ currentUrl NOTIFY..." src/file/extractor/app.h (line 62) <https://git.reviewboard.kde.org/r/124162/#comment56175> const QDBusMessage& ? - Vishesh Handa On June 27, 2015, 12:32 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124162/ > ----------------------------------------------------------- > > (Updated June 27, 2015, 12:32 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Every monitor now, has to register with the extractor. The extractor keeps > track of running monitors and only sends out the urlChanged signal if one or > more monitors are running. > > > Diffs > ----- > > src/file/extractor/app.h f8b8834 > src/file/extractor/app.cpp e288285 > src/file/extractor/main.cpp 58ddbeb > src/file/extractor/org.kde.balooExtractor.xml PRE-CREATION > src/tools/baloo-monitor/CMakeLists.txt b80d129 > src/tools/baloo-monitor/monitor.h 708ad6a > src/tools/baloo-monitor/monitor.cpp 9957424 > > Diff: https://git.reviewboard.kde.org/r/124162/diff/ > > > Testing > ------- > > Tested using dbus-monitor, extractor only exports urls when monitor is > running. > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
