> On June 30, 2015, 3:14 p.m., Stefan Brüns wrote: > > src/file/extractor/org.kde.balooExtractor.xml, line 3 > > <https://git.reviewboard.kde.org/r/124162/diff/3/?file=381776#file381776line3> > > > > Any reason to name the service org.kde.baloo.extractor, but the > > interface org.kde.balooExtractor? > > > > I think both should be the same. > > Pinak Ahuja wrote: > I was running into namespace issues in the proxy classes with > org.kde.baloo.extractor, as we already have an interface named org.kde.baloo > (because of that interface we have a proxy interface org::kde::baloo and we > cannot have org::kde::baloo::extractor). Maybe be should rename org.kde.baloo > interface to org.kde.baloo.main or generate proxy classes without namespaces?
What can't we have both org::kde::baloo and org::kde::baloo::extractor? I'm okay with it both ways though I would prefer what Stefan says. Ship it. - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124162/#review81905 ----------------------------------------------------------- On June 30, 2015, 12:11 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124162/ > ----------------------------------------------------------- > > (Updated June 30, 2015, 12:11 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Every monitor now, has to register with the extractor. The extractor keeps > track of running monitors and only sends out the urlChanged signal if one or > more monitors are running. > > > Diffs > ----- > > src/file/extractor/app.h f8b8834 > src/file/extractor/app.cpp e288285 > src/file/extractor/main.cpp 58ddbeb > src/file/extractor/org.kde.balooExtractor.xml PRE-CREATION > src/tools/baloo-monitor/CMakeLists.txt 646f701 > src/tools/baloo-monitor/monitor.h c7dc76f > src/tools/baloo-monitor/monitor.cpp 46e7a02 > > Diff: https://git.reviewboard.kde.org/r/124162/diff/ > > > Testing > ------- > > Tested using dbus-monitor, extractor only exports urls when monitor is > running. > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
