> On Sept. 23, 2015, 7:11 p.m., Armin K. wrote: > > You may want to s/QLatin1String/QStringLiteral/ to reduce allocations. > > Otherwise, looks nice.
The rest of balooctl uses QLatin1String, so let's stick with that for now. I'm also not sure whether QStringLiteral == QLatin1String, QStringLiteral may also encode unicode strings. - Boudhayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125361/#review85819 ----------------------------------------------------------- On Sept. 23, 2015, 7:01 p.m., Boudhayan Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125361/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2015, 7:01 p.m.) > > > Review request for Baloo, Pinak Ahuja and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Add a check to balooctl status to see if Indexing-Enabled is false, in which > case show a nice output. The current output shows a scary "The Baloo Index > could not be opened" > > > Diffs > ----- > > src/tools/balooctl/main.cpp 96d68d4 > > Diff: https://git.reviewboard.kde.org/r/125361/diff/ > > > Testing > ------- > > String shows. > > > Thanks, > > Boudhayan Gupta > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
