----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125361/#review85829 -----------------------------------------------------------
Ship it! src/tools/balooctl/main.cpp (line 47) <https://git.reviewboard.kde.org/r/125361/#comment59275> Extra whitespace at the end of the line src/tools/balooctl/main.cpp (line 116) <https://git.reviewboard.kde.org/r/125361/#comment59274> Please fix the coding style. `if (condition)` not `if(condition)` - Vishesh Handa On Sept. 23, 2015, 2:30 p.m., Boudhayan Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125361/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2015, 2:30 p.m.) > > > Review request for Baloo, Pinak Ahuja and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Add a check to balooctl status to see if Indexing-Enabled is false, in which > case show a nice output. The current output shows a scary "The Baloo Index > could not be opened" > > > Diffs > ----- > > src/tools/balooctl/main.cpp 96d68d4 > > Diff: https://git.reviewboard.kde.org/r/125361/diff/ > > > Testing > ------- > > String shows. > > > Thanks, > > Boudhayan Gupta > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
