-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125424/#review86022
-----------------------------------------------------------
First note: it would be useful if it would show not only IDs of documents, but
also full paths/names.
Second note: please also add 'reversed' check for postingDB. Right now it
checks only in each pair "Document ID -> Term" has corresponding pair "Term ->
Document ID" in PostingDB. But it should also check that each "Term -> Document
ID" link in PostingDB has corresponding term in DocumentDB.
I noted this because checkDb shows some corrupted data in DB, but it doesn't
show files I expected (that has weird type 'directory' being just PDFs). That's
because I can search it both by type "Document" and type "Folder":
# baloosearch --type directory 'result.pdf'
/store/documents/[...]/results.pdf
# baloosearch --type document 'result.pdf'
/store/documents/[...]/results.pdf
Reversed check would reveal this kind of corruption.
- Igor Poboiko
On Сен. 27, 2015, 5:33 п.п., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125424/
> -----------------------------------------------------------
>
> (Updated Сен. 27, 2015, 5:33 п.п.)
>
>
> Review request for Baloo, Pinak Ahuja and Igor Poboiko.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Balooctl: Add checkDb command
>
> This command can be used by developers to check if their PostingDb and
> DocumentUrlDB is in a valid state. We have a few bugs caused because all
> the databases are not correctly updated. This will help us diagnose this
> better.
>
> I am trying to diagnose the bug revealed by review 125362. Still not entirely
> sure.
>
>
> Diffs
> -----
>
> src/engine/transaction.h 845d9f0
> src/engine/transaction.cpp 8e9700c
> src/tools/balooctl/main.cpp 0e74761
>
> Diff: https://git.reviewboard.kde.org/r/125424/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
