----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125424/#review86024 -----------------------------------------------------------
Ship it! Oh, I didn't know that you can feed an ID to balooshow. Yeah, in that case I agree with you, URL is not necessary. Full check now takes some time... It would be useful if it would also report progress, since we know the total amount of terms. For example I would suggest reporting each 5% or 10% of terms processed with a message like "Progress: 30% (elapsed time: 10 min, ETA: 25 min)". But I guess it's needed only in the last check you added, it's the slowest one. Good news: after applying patch from [https://git.reviewboard.kde.org/r/125362/](my review), it does not report any invalid entry :) - Igor Poboiko On Сен. 27, 2015, 11:51 п.п., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125424/ > ----------------------------------------------------------- > > (Updated Сен. 27, 2015, 11:51 п.п.) > > > Review request for Baloo, Pinak Ahuja and Igor Poboiko. > > > Repository: baloo > > > Description > ------- > > Balooctl: Add checkDb command > > This command can be used by developers to check if their PostingDb and > DocumentUrlDB is in a valid state. We have a few bugs caused because all > the databases are not correctly updated. This will help us diagnose this > better. > > I am trying to diagnose the bug revealed by review 125362. Still not entirely > sure. > > > Diffs > ----- > > src/engine/transaction.h 845d9f0 > src/engine/transaction.cpp 8e9700c > src/tools/balooctl/main.cpp 0e74761 > > Diff: https://git.reviewboard.kde.org/r/125424/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
