----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125429/#review86113 -----------------------------------------------------------
Ship it! src/file/filecontentindexer.cpp (line 72) <https://git.reviewboard.kde.org/r/125429/#comment59387> This fixes the warning. Though I'm not sure why it does. From what I understand this emits newBatchtime signal from the main thread right? I don't understand why QDbus cares about this signal considering we are not exporting it. src/file/filecontentindexer.cpp (line 84) <https://git.reviewboard.kde.org/r/125429/#comment59386> Wouldn't this slot be executed in the main thread? We most probably don't need this. - Pinak Ahuja On Sept. 27, 2015, 9:46 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125429/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2015, 9:46 p.m.) > > > Review request for Baloo and Pinak Ahuja. > > > Repository: baloo > > > Description > ------- > > Fix dbus warnings > > We cannot emit dbus signals from a different thread than the thread the > object has an affinity to. > > > Diffs > ----- > > src/file/filecontentindexer.cpp 4323c3f > > Diff: https://git.reviewboard.kde.org/r/125429/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
