> On Sept. 29, 2015, 2:24 p.m., Pinak Ahuja wrote: > > src/file/filecontentindexer.cpp, line 84 > > <https://git.reviewboard.kde.org/r/125429/diff/1/?file=408580#file408580line84> > > > > Wouldn't this slot be executed in the main thread? We most probably > > don't need this.
I'm confused. We do need it since dbus signals need to be emitted in the main thread. - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125429/#review86113 ----------------------------------------------------------- On Sept. 30, 2015, 4:41 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125429/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2015, 4:41 p.m.) > > > Review request for Baloo and Pinak Ahuja. > > > Repository: baloo > > > Description > ------- > > Fix dbus warnings > > We cannot emit dbus signals from a different thread than the thread the > object has an affinity to. > > > Diffs > ----- > > src/file/filecontentindexer.cpp 4323c3f > > Diff: https://git.reviewboard.kde.org/r/125429/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
