-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125430/#review86116
-----------------------------------------------------------

Ship it!


Makes sense, didn't realize multiple monitors can call the methods at the same 
time. :)


src/file/filecontentindexer.cpp (line 80)
<https://git.reviewboard.kde.org/r/125430/#comment59388>

    Maybe we can move this below m_filePath = filePath; ?
    
    Wouldn't make a lot of difference but I don't want the CurrentFilePath 
property update being blocked due to the mutex


- Pinak Ahuja


On Sept. 27, 2015, 9:48 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125430/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2015, 9:48 p.m.)
> 
> 
> Review request for Baloo.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> See diff
> 
> 
> Diffs
> -----
> 
>   src/file/filecontentindexer.h 6ecd41c 
>   src/file/filecontentindexer.cpp 4323c3f 
> 
> Diff: https://git.reviewboard.kde.org/r/125430/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Reply via email to