> On Sept. 29, 2015, 3:10 p.m., Pinak Ahuja wrote: > > Oh wait, I don't think this is needed all slots that modify m_monitors run > > in the creation/main thread also m_currentFile is updated in the > > slotIndexingFile and read in the QProperty getter (I should probably make > > it const) both of which should run in the creation/main thread.
My bad. I didn't realize slotIndexingFile is called from the main thread and not from the content indexer's thread. This patch is not required. - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125430/#review86118 ----------------------------------------------------------- On Sept. 27, 2015, 9:48 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125430/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2015, 9:48 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > See diff > > > Diffs > ----- > > src/file/filecontentindexer.h 6ecd41c > src/file/filecontentindexer.cpp 4323c3f > > Diff: https://git.reviewboard.kde.org/r/125430/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
