----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128183/#review96470 -----------------------------------------------------------
This looks very much like something that can be unittested. Is there a unittest framework for this "query parser" ? src/lib/advancedqueryparser.cpp (line 156) <https://git.reviewboard.kde.org/r/128183/#comment65166> withouts -> without encounterd -> encountered Shouldn't this qDebug() print out "text" ? Otherwise we get a generic debug statement with no context as to why it's shown. src/lib/advancedqueryparser.cpp (line 159) <https://git.reviewboard.kde.org/r/128183/#comment65167> use 'property' here, to avoid calling .value().toString() again - David Faure On June 14, 2016, 10:46 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128183/ > ----------------------------------------------------------- > > (Updated June 14, 2016, 10:46 a.m.) > > > Review request for Baloo and David Faure. > > > Repository: baloo > > > Description > ------- > > Queries like =:2 make our QueryParser behave unexpectedly, now if we have a > binary operator without a first arg we just return an empty term. > > > Diffs > ----- > > src/lib/advancedqueryparser.cpp a42a3c6 > > Diff: https://git.reviewboard.kde.org/r/128183/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
