> On June 14, 2016, 7:04 p.m., David Faure wrote: > > autotests/unit/lib/advancedqueryparsertest.cpp, line 197 > > <https://git.reviewboard.kde.org/r/128183/diff/2/?file=468779#file468779line197> > > > > You could actually use QTest::ignoreMessage() here, to silence the > > qDebug and ensure it worked (this would have detected the issue below :-)
couldn't get that working properly, just pushed as is. - Pinak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128183/#review96498 ----------------------------------------------------------- On June 14, 2016, 8:23 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128183/ > ----------------------------------------------------------- > > (Updated June 14, 2016, 8:23 p.m.) > > > Review request for Baloo and David Faure. > > > Repository: baloo > > > Description > ------- > > Queries like =:2 make our QueryParser behave unexpectedly, now if we have a > binary operator without a first arg we just return an empty term. > > > Diffs > ----- > > autotests/unit/lib/advancedqueryparsertest.cpp 05696a2 > src/lib/advancedqueryparser.cpp a42a3c6 > > Diff: https://git.reviewboard.kde.org/r/128183/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
