On Thursday 24 July 2008 12:02:08 Ben Taylor wrote:
> On Wed, Jul 23, 2008 at 4:47 PM, Albertson, Brett <bretta at consonus.com> 
wrote:
> > Here are some patches to allow kdesupport, kdelibs, and kdebase to
> > compile properly on my machine.  There's still a newly introduced problem
> > in kdeedu which I haven't had time to fix yet.  The diff is relative to
> > Build/Patches.

Brett, which KDE version are you working with (trunk or 4.1?) That's a little 
unclear from the patches. In any case, it might be easier to submit the patch 
itself rather than patches to the patches; that's slightly easier to sort out 
:)

> > +Index: kdeui/icons/kiconloader.cpp
> > +===================================================================
> > +--- kdeui/icons/kiconloader.cpp        (revision 836933)
> > ++++ kdeui/icons/kiconloader.cpp        (working copy)
> > +@@ -59,11 +59,7 @@
> > +
> > + // The following define exists because the Qt SVG renderer needs
> > + // to be improved. This will be removed soon. (ereslibre)
> > +-#ifdef QT_VERSION >= 0x040400
>
> shouldn't this be
>
> #if QT_VERSION >= 0x040400

This has gone away in 4.1 branch and in trunk, since the SVG renderer isn't 
fixed.



Reply via email to