tcanabrava requested changes to this revision.
tcanabrava added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> view.cpp:3691-3712
> +void View::updateAnim()
> +{
> + const int MAX = 11;
> + const int ANIM_MS = MAX*16;
> +
> + if (m_animInfo.step >= MAX)
> + {
It seems that you are interpolating by hand, why don't you try to use something
like a QEasingCurve + a QPropertyAnimation?
> view.h:637-640
> + QPointF beginTL;
> + QPointF beginBR;
> + QPointF endTL;
> + QPointF endBR;
What's TL and BR? Be explicit in the code.
REPOSITORY
R334 KmPlot
REVISION DETAIL
https://phabricator.kde.org/D17120
To: yurchor, #kde_edu, tcanabrava
Cc: tcanabrava, kde-edu, kde-doc-english, skadinna, narvaez, apol
