----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/#review37565 -----------------------------------------------------------
khtml/khtml_part.cpp <http://git.reviewboard.kde.org/r/111916/#comment27760> Is this variable still used? khtml/khtml_part.cpp <http://git.reviewboard.kde.org/r/111916/#comment27761> You reversed the condition. stat() returns 0 on success. So, no "!" before exists. khtml/khtml_part.cpp <http://git.reviewboard.kde.org/r/111916/#comment27763> That's not what lstat does.... The case where stat() fails and lstat() succeeds is the case of a broken symlink. In that case, QFileInfo::exists() returns false. I guess all we can do then is skip this second check, and use if (info.isSymlink()) below, without ok&& in front. I.e. always go into the symlink code, whether the symlink is valid or broken. - David Faure On Aug. 12, 2013, 9:35 a.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111916/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2013, 9:35 a.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Port khtml_part away from kde_file.h > > > Diffs > ----- > > khtml/khtml_part.cpp d944a29 > > Diff: http://git.reviewboard.kde.org/r/111916/diff/ > > > Testing > ------- > > Compiles. The tests seem to segfault with and without this patch. I'll try to > diagnose it. > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
