> On Aug. 12, 2013, 9:40 a.m., David Faure wrote: > > khtml/khtml_part.cpp, line 3580 > > <http://git.reviewboard.kde.org/r/111916/diff/2/?file=178128#file178128line3580> > > > > Is this variable still used? > > Vishesh Handa wrote: > Yes. A couple of lines below - > > int n = readlink ( path.toLocal8Bit().data(), buff_two, 1022); > > I can replace it over here if you want?
That's what should use QFileInfo::symlinkTarget()... - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/#review37565 ----------------------------------------------------------- On Aug. 12, 2013, 10:15 a.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111916/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2013, 10:15 a.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Port khtml_part away from kde_file.h > > > Diffs > ----- > > khtml/khtml_part.cpp d944a29 > > Diff: http://git.reviewboard.kde.org/r/111916/diff/ > > > Testing > ------- > > Compiles. The tests seem to segfault with and without this patch. I'll try to > diagnose it. > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
