----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review41018 -----------------------------------------------------------
staging/kemoticons/src/core/kemoticonsprovider.h <http://git.reviewboard.kde.org/r/112984/#comment30112> Use KEMOTICONS_DEPRECATED I don't really understand what's better from ::save instead of ::saveTheme. Is it just the naming? They seem to do the same. - Aleix Pol Gonzalez On Sept. 28, 2013, 9:19 p.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112984/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2013, 9:19 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Adjust API in KEmoticons framework: KEmoticonsProvider::save() > > -To make KEmoticons API more consistent, deprecate KEmoticonsProvider::save() > and prefer saveTheme() instead. > -Adjust plugins. > -Before the cleanup, KEmoticonsTheme was calling KEmoticonsProvider::save(), > which was empty. Now it's a pure virtual function. Therefore, I deprecate > it and advice subclassing KEmoticonsProvider. > > > Diffs > ----- > > staging/kemoticons/src/core/kemoticonsprovider.h > 85fc7efb8923d76476f0a16f70f8ebb15e451081 > staging/kemoticons/src/core/kemoticonstheme.h > b8b25f7607d3741dda78d6302c1ed81fbc9211a0 > staging/kemoticons/src/core/kemoticonstheme.cpp > ed3407cdd45c84d91f2d0057e108b760ff696ff2 > staging/kemoticons/src/providers/adium/adium_emoticons.h > 039a267679919c968bbe4d12c35abb90cf1bcc9b > staging/kemoticons/src/providers/adium/adium_emoticons.cpp > a3aaa0fdc0b3dcc862f98865d2e6419e716f4f17 > staging/kemoticons/src/providers/kde/kde_emoticons.h > 8cba6b194eee1543bf13f1177a0e4092f1a10943 > staging/kemoticons/src/providers/kde/kde_emoticons.cpp > 5b5114a14dd94a6ebcba8a6f7dd163f73048189a > staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h > 70bafa3fe4ba25c9d6a69634024b2c157235e674 > staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp > e9f89eecce3d6e6407113a84cb5200ff66564c19 > staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h > 0873a635a300e0ed8e38b1d59a535d6ec15b99cb > staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp > 0dc92ed092d87a559fe7fa1a40e804843ab73d59 > > Diff: http://git.reviewboard.kde.org/r/112984/diff/ > > > Testing > ------- > > It builds. It installs. Tests pass. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel