----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review41164 -----------------------------------------------------------
staging/kemoticons/src/core/kemoticonsprovider.h <http://git.reviewboard.kde.org/r/112984/#comment30216> You probably don't want save() to be virtual anymore because: - The size of the class is going to change if you build with or without KDE_NO_DEPRECATED, which could lead to BIC issues and build failures if one creates implements a KEmoticonsProvider while building with KDE_NO_DEPRECATED: it would build for him but not for others. - Code implementing the interface *must* implement both save() and saveTheme(), so better implement save() in KEmoticonsProvider as a call to saveTheme(). You can then remove all implementations to save(). staging/kemoticons/src/core/kemoticonsprovider.h <http://git.reviewboard.kde.org/r/112984/#comment30215> Missing `@since 5.0` - Aurélien Gâteau On Oct. 1, 2013, 10:45 p.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112984/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2013, 10:45 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Adjust API in KEmoticons framework: KEmoticonsProvider::save() > > -To make KEmoticons API more consistent, deprecate KEmoticonsProvider::save() > and prefer saveTheme() instead. > -Adjust plugins. > -Before the cleanup, KEmoticonsTheme was calling KEmoticonsProvider::save(), > which was empty. Now it's a pure virtual function. Therefore, I deprecate > it and advice subclassing KEmoticonsProvider. > > > Diffs > ----- > > staging/kemoticons/src/core/kemoticonsprovider.h 85fc7ef > staging/kemoticons/src/core/kemoticonstheme.h b8b25f7 > staging/kemoticons/src/core/kemoticonstheme.cpp ed3407c > staging/kemoticons/src/providers/adium/adium_emoticons.h 039a267 > staging/kemoticons/src/providers/adium/adium_emoticons.cpp a3aaa0f > staging/kemoticons/src/providers/kde/kde_emoticons.h 8cba6b1 > staging/kemoticons/src/providers/kde/kde_emoticons.cpp 5b5114a > staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h 70bafa3 > staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp e9f89ee > staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h 0873a63 > staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 0dc92ed > > Diff: http://git.reviewboard.kde.org/r/112984/diff/ > > > Testing > ------- > > It builds. It installs. Tests pass. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
