On Sunday 08 December 2013 18:44:59 Martin Graesslin wrote: > On Sunday 08 December 2013 18:04:45 Albert Astals Cid wrote: > > El Diumenge, 8 de desembre de 2013, a les 10:16:36, Martin Graesslin va > > > > escriure: > > > Hi, > > > > > > at the moment KGlobalAccel is part of XmlGui which I consider > > > semantically > > > wrong. Global shortcuts have nothing to do with XmlGui and there are > > > quite > > > some examples for applications which need global shortcuts but do not > > > use > > > xml gui (e.g. everything in the desktop shell). > > > > > > My suggestion is to move the following source files into an own > > > framework: > > > * kglobalaccel.cpp > > > * kglobalaccel.h > > > * kglobalaccel_p.h > > > * kglobalshortcutinfo.cpp > > > * kglobalshortcutinfo.h > > > * kglobalshortcutinfo_dbus.cpp > > > * kglobalshortcutinfo_p.h > > > * org.kde.kglobalaccel.Component.xml > > > * org.kde.KGlobalAccel.xml > > > > > > From checking the source files this would become a tier1 framework as > > > the > > > dependencies are: > > > * QtCore > > > * QtDBus > > > * QtWidgets > > > * QtX11Extras > > > > > > Opinions? > > > > Not an oposition but... > > > > Is there no other tier1 framework where it would fit logically and > > dependency wise? > > Probably Kevin or David can better comment on it. For me the only somewhat > fitting framework would be KWidgetsAddons, but I don't know whether it would > be OK to have more dependencies in that framework. WidgetsAddons only > depends on Widgets, but GlobalAccel also needs DBus and X11Extras.
KWidgetsAddons doesn't fit indeed. It has to keep depending on QtWidgets only. Cheers. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
