On Sunday 08 December 2013 18:42:25 Kevin Ottens wrote: > On Sunday 08 December 2013 10:16:36 Martin Graesslin wrote: > > Hi, > > > > at the moment KGlobalAccel is part of XmlGui which I consider semantically > > wrong. Global shortcuts have nothing to do with XmlGui and there are quite > > some examples for applications which need global shortcuts but do not use > > xml gui (e.g. everything in the desktop shell). > > > > My suggestion is to move the following source files into an own framework: > > * kglobalaccel.cpp > > * kglobalaccel.h > > * kglobalaccel_p.h > > * kglobalshortcutinfo.cpp > > * kglobalshortcutinfo.h > > * kglobalshortcutinfo_dbus.cpp > > * kglobalshortcutinfo_p.h > > * org.kde.kglobalaccel.Component.xml > > * org.kde.KGlobalAccel.xml > > > > From checking the source files this would become a tier1 framework as the > > dependencies are: > > * QtCore > > * QtDBus > > * QtWidgets > > * QtX11Extras > > > > Opinions? > > It ended up in XmlGui because otherwise we would have a framework with a > just a pair of public classes. Now I see where you come from from kwin > point of view, so let's split it out after all. > > Now the trick is that we're about to split (pending emptying the patch > queue), so if you want it please make it happen in the next couple of days. Yes, I'm aware of that and that's why I brought it up today to make sure that I can have a working patch till Tuesday if there is agreement on it.
Cheers Martin
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
