> On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: > > KF5DocToolsMacros.cmake, lines 166-172 > > <https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166> > > > > These should *not* be renamed, as they are compatibility macros. > > However, they should probably be moved to kde4support. > > Aleix Pol Gonzalez wrote: > I wouldn't rename it indeed. > > Moving it to KDE4Support can be good indeed, although it kind of defeats > the purpose, as you'll need to actually depend on KDE4Support to get the > warning. > > David Narváez wrote: > Luigi, your call.
Well, most projects will start off depending on KDE4Support anyway, and if you don't use it I think you should just get an error about the macro not being found. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/#review47592 ----------------------------------------------------------- On Jan. 18, 2014, 1:16 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115077/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2014, 1:16 p.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > ------- > > Part of the overall task of removing mentions of KDE4 from the code. > > > Diffs > ----- > > KF5DocToolsMacros.cmake 191a2c5 > > Diff: https://git.reviewboard.kde.org/r/115077/diff/ > > > Testing > ------- > > > Thanks, > > David Narváez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
