----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/#review48418 -----------------------------------------------------------
We use to do so in the CMake files (as more than one source file may use it). - Andrius da Costa Ribas On Jan. 27, 2014, 9:32 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115344/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2014, 9:32 p.m.) > > > Review request for KDE Frameworks and kdewin. > > > Repository: kunitconversion > > > Description > ------- > > With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined > > Is it okay to put the define in the source file, or should I rather put it in > the CMake code? > > > Diffs > ----- > > src/angle.cpp 4df1981930e6459a7d2486caffaee6fd439976d0 > > Diff: https://git.reviewboard.kde.org/r/115344/diff/ > > > Testing > ------- > > didn't compile before, does now > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
