----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/ -----------------------------------------------------------
(Updated Feb. 3, 2014, 7:46 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks. Repository: kunitconversion Description ------- With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined Is it okay to put the define in the source file, or should I rather put it in the CMake code? Diffs ----- src/CMakeLists.txt aefd6abe964d19177a3514f9c01022141af0425b Diff: https://git.reviewboard.kde.org/r/115344/diff/ Testing ------- didn't compile before, does now Thanks, Alexander Richardson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
