sitter added inline comments. INLINE COMMENTS
> bruns wrote in kio_sftp.cpp:1935 > Dependent on the file system, this will no longer catch `partFile.isDir()`. > stat.st_size is only defined for regular files and symlinks, for all other > types it is implementation defined. E.g. XFS and Btrfs return 0 for empty > directories. Your comment is dazzling. What you meant to say is that the size check ought to be after the dir check? > bruns wrote in kio_sftp.cpp:1936 > should be `if (!partFile.isFile())` - we cant resume a pipe or socket ... Please make a diff. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27872 To: sitter, ngraham, feverfew, bruns Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
