apol added a comment.

  Some concerns at the documentation level. Looks good overall.

INLINE COMMENTS

> display.h:287
>       */
>      XdgOutputManagerInterface *createXdgOutputManager(QObject *parent = 
> nullptr);
>  

Should we deprecate the one without version?

> xdgoutput_interface.h:105
>       * It should be set once before the first done call
> -     * @since 5.XDGOUTPUT
> +     * Version 2 only
> +     * @since 5.69

I'd write something like `Only effective since version UnstableV2`.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28498

To: davidedmundson, #kwin
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

Reply via email to