davidedmundson marked an inline comment as done. davidedmundson added inline comments.
INLINE COMMENTS > apol wrote in display.h:287 > Should we deprecate the one without version? I'll add a doc. I don't want to waste time with the macro stuff given we know there's only one user. > anthonyfieroni wrote in display.h:296 > explicit, also take enum class by value. I agree it's weird to take a const&, but it's what the others do REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28498 To: davidedmundson, #kwin Cc: anthonyfieroni, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns