fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> globalshortcutsregistry.cpp:274
> + auto disabledComponents = KConfigGroup(&_config,
> "disabledComponents").readEntry("disabled", QStringList());
> for (const QString &groupName : groupList)
> {
`disabledComponents` is the group name, right? It would also be part of
`groupList`, so it would try to load it as shortcut...
> globalshortcutsregistry.cpp:333
> for (const QString &desktopFile : lstDesktopFiles) {
> - if (_components.contains(desktopFile)) {
> + if (_components.contains(desktopFile) ||
> disabledComponents.contains(desktopFile)) {
> continue;
Is `desktopFile` the equivalent to `component->uniqueName()`? I would assume
no, so this check might need to be moved after the `KServiceActionComponent`
construction
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D28856
To: davidre, davidedmundson, fvogt, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
