davidre added inline comments.

INLINE COMMENTS

> globalshortcutsregistry.cpp:274
> +    auto disabledComponents = KConfigGroup(&_config, 
> "disabledComponents").readEntry("disabled", QStringList());
>      for (const QString &groupName : groupList)
>          {

good point

> globalshortcutsregistry.cpp:333
>              for (const QString &desktopFile : lstDesktopFiles) {
> -                if (_components.contains(desktopFile)) {
> +                if (_components.contains(desktopFile) || 
> disabledComponents.contains(desktopFile)) {
>                      continue;

It actually is if you follow the constructor chain

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D28856

To: davidre, davidedmundson, fvogt, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Reply via email to