meven added inline comments.
INLINE COMMENTS
> thumbnail.cpp:738
> + if (!m_thumbnailDirDeviceId) {
> + struct stat baseStat;
> + if (!lstat(QFile::encodeName(m_thumbBasePath).data(),
> &baseStat)) {
Can't you move this out of the loop ? Since `m_thumbBasePath` does not change.
> thumbnail.h:87
> + dev_t m_thumbnailDirDeviceId = 0;
> + short allowDirCatche;
> };
s/allowDirCatche/allowDirCached
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D28745
To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik,
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde,
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros,
emmanuelp, rdieter, mikesomov
