kossebau added a comment.
In D29299#660453 <https://phabricator.kde.org/D29299#660453>, @pino wrote: > The problem is that ki18n_install() is rarely used manually, and generally it is appended by the release scripts to the top-level CMakeLists.txt file that goes into the tarballs. While being an orthogonal topic, IMHO this should be changed. There is just too much magic going on when it comes to translations, the avaerage KDE devloper does not understand it, at least by what I gathered :) Also would some not consider it a good practice to patch sources before adding to the tarball, making the sources different to what is tagged. Personally I would favour rather explicit statements, with a comment explaining why there is no po/ file in the sources and a link to a website where to learn more about things. In D29299#660465 <https://phabricator.kde.org/D29299#660465>, @pino wrote: > Also, your patch basically includes D29136 <https://phabricator.kde.org/D29136> in the case of no DESTINATION parameter specified, hence my suggestion is: > > - edit D29136 <https://phabricator.kde.org/D29136> to do the fallback using the same logic introduced here: this way marble is already fixed with no other changes, and ki18n_install will work also with KDE_INSTALL_DIRS_NO_DEPRECATED (e.g. for release-service packages) > - have this to add the DESTINATION parameter, so packages can opt-in to use it if they can/want Not exactly sure what you mean? Do you want two separate commits/reviews, one per issue? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29299 To: kossebau, ilic, heikobecker, #frameworks, aacid, ltoscano Cc: pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
