kossebau added a comment.
In D29299#660468 <https://phabricator.kde.org/D29299#660468>, @pino wrote: > In D29299#660466 <https://phabricator.kde.org/D29299#660466>, @kossebau wrote: > > > In D29299#660465 <https://phabricator.kde.org/D29299#660465>, @pino wrote: > > > > > Also, your patch basically includes D29136 <https://phabricator.kde.org/D29136> in the case of no DESTINATION parameter specified, hence my suggestion is: > > > > > > - edit D29136 <https://phabricator.kde.org/D29136> to do the fallback using the same logic introduced here: this way marble is already fixed with no other changes, and ki18n_install will work also with KDE_INSTALL_DIRS_NO_DEPRECATED (e.g. for release-service packages) > > > - have this to add the DESTINATION parameter, so packages can opt-in to use it if they can/want > > > > > > Not exactly sure what you mean? Do you want two separate commits/reviews, one per issue? > > > Yes, and we have them already: D29136 <https://phabricator.kde.org/D29136> (to reopen) and this (which would need to rebased on the former). D29136 <https://phabricator.kde.org/D29136> in the current version though changes behaviour by favouring KDE_INSTALL_LOCALEDIR over LOCALE_INSTALL_DIR. Which at least in theory might somewhere in some distant galaxy break things ;) Strapped this patch here into D29303 <https://phabricator.kde.org/D29303> as alternative for trhe given aspect. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29299 To: kossebau, ilic, heikobecker, #frameworks, aacid, ltoscano Cc: pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
