kossebau added inline comments. INLINE COMMENTS
> aacid wrote in kiconloader.cpp:1142 > I just realized that function is private, not really easy to use :/ > > anyhow do you think we should remove svgz? > > Also i think using > > const QStringList extensions = { QStringLiteral(".png"), > QStringLiteral(".svg"), QStringLiteral(".svgz"), QStringLiteral(".xpm") }; > > should be a bit faster You could make this even a stack-only array, even more fast due to no heap alloc ;) const QString extensions[] = { QStringLiteral(".png"), QStringLiteral(".svg"), QStringLiteral(".svgz") << QStringLiteral(".xpm" }; REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29390 To: nicolasfella, #plasma, #frameworks Cc: kossebau, aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns