usta added inline comments.


> jobtest.cpp:465
> +{
> +    QString writeTest = dir + "/fsXattrTestFile";
> +    createTestFile(writeTest);

const ?

> file_unix.cpp:1517
>          }
>          acl = acl_from_text(ACLString.toLatin1().constData());
>          if (acl_valid(acl) == 0) {     // let's be safe

isnt this ignoring acl_from_mode part ? I mean not sure but i think we need to 
check if it is nullptr or not before assigning it otherwise we will ignore the 
acl_from_mode part.


To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

Reply via email to