----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116766/#review52804 -----------------------------------------------------------
Looks fine to me. - Kevin Ottens On March 12, 2014, 3:47 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116766/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 3:47 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kservice > > > Description > ------- > > Use a desktop file we might find for testing KServiceActions > > The screensaver stuff isn't ported to frameworks 5 yet, so looking for > those desktop files won't work. This uses something that might actually > be installed instead. > > > Diffs > ----- > > autotests/kservicetest.h aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 > autotests/kservicetest.cpp 711fb9b649e580ad474b0cdecd26dcdbfdc302a2 > > Diff: https://git.reviewboard.kde.org/r/116766/diff/ > > > Testing > ------- > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
